Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7623: Fixes an issue where Email action with Logs turned on will fail for the nested form with Attach Submission PDF #1689

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

alexandraRamanenka
Copy link
Contributor

@alexandraRamanenka alexandraRamanenka commented Jan 24, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7623

Description

What changed?

Because we are calling next() to prevent blocking while sending emails, after the response is sent, req.params are cleared. We already was restoring them after emailer.getParams got resolved, but is some scenariouse, the response is not sent at that moment, so req.params are getting cleared after we restored them. So I adjusted this solution to restore req.params after the response is sent by using 'finish' event.

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

Use this section to list any dependent changes/PRs in other Form.io modules

How has this PR been tested?

Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

…fail for the nested form with Attach Submission PDF
@brendanbond brendanbond merged commit 77fb7ac into master Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants