Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-6966: Fixes missing address component data in csv exported submissions #1750

Merged
merged 3 commits into from
May 30, 2024

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-6966

Description

What changed?

Address component data was not always present in csv submissions export, which this PR fixes.

Dependencies

None

How has this PR been tested?

I've updated automated tests, so to cover different address providers and manual input mode.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 5b62591 into master May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants