Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the issue to re-render Formio Builder on state change #555

Closed
wants to merge 1 commit into from
Closed

fixed the issue to re-render Formio Builder on state change #555

wants to merge 1 commit into from

Conversation

BhaveshVarma1
Copy link

#what does this PR does
I have optimized 3 files and resolved the re-render Formio Builder on State Change by changing these 3 files : Form.jsx , FormBuilder.jsx , FormEdit.jsx

Fixes #553

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BhaveshVarma1 thanks so much for the contribution. I wonder if we can tighten this up a bit to solely focus on #553 and the builder - I don't think we're quite ready to do a wholesale refactor on, for example, Form.jsx. There are also hopefully some changes coming to the Form component in particular that will conflict with the changes you've made.

Also, it looks like you're using an outside formatter? Let me know if the pre-commit hook (which should be formatting your files) isn't working for you. Thanks!

@BhaveshVarma1
Copy link
Author

Okay sir , I understood your request . I will try to quickly do the necessary changes again only for the "ISSUE #553 " and update it as soon as I can .
Thankyou

@BhaveshVarma1 BhaveshVarma1 closed this by deleting the head repository Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants