Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select prevents rendering if options are empty #129

Closed
RDelorier opened this issue Mar 8, 2022 · 3 comments
Closed

Select prevents rendering if options are empty #129

RDelorier opened this issue Mar 8, 2022 · 3 comments
Assignees
@justin-schroeder
Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@RDelorier
Copy link

Reproduction

https://formkit.link/2503ee4a3a9247b2ded2e5a4d6624594

Describe the bug

Select inputs prevent entire form from rendering if there is no placeholder and the options are empty.

When loading options for a select async the initial array is empty. If there is no placeholder then the input attempts to set the value using the first available option which doesn't exist.

Environment

• OS: macOS Monterey
• Browser chrome
• Version 98.0.4758.109 (Official Build) (x86_64)
@RDelorier RDelorier added the 🐛 bug-report Bug is reported, but not verified by team label Mar 8, 2022
@justin-schroeder
Copy link
Member

hmm, yeah thats no bueno. thanks for the report 👍

@justin-schroeder justin-schroeder added 🐛 bug Verified bug by team and removed 🐛 bug-report Bug is reported, but not verified by team labels Mar 8, 2022
@justin-schroeder justin-schroeder added this to the Beta 6 milestone Mar 8, 2022
@justin-schroeder justin-schroeder self-assigned this Mar 8, 2022
justin-schroeder added a commit that referenced this issue Mar 8, 2022
@justin-schroeder
Adds backing test for #129
0bb3632
@justin-schroeder
Copy link
Member

This is fixed and published on the @next tag. You can see it working in the playground on the beta.6 version:

https://formkit.link/6cc4859a272eadfbc848f7706fca8a72

(might need a hard refresh)

@justin-schroeder justin-schroeder added the 🚀 release-ready Feature or fix is complete and on an upcoming release branch label Mar 8, 2022
@RDelorier
Copy link
Author

Awesome, that was fast 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justin-schroeder justin-schroeder

Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin-schroeder @RDelorier