Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs should be disabled whilst form is in loading state #44

Closed
hisuwh opened this issue Jan 26, 2022 · 1 comment
Closed

Inputs should be disabled whilst form is in loading state #44

hisuwh opened this issue Jan 26, 2022 · 1 comment
Labels
🪄 enhancement New feature or request 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@hisuwh
Copy link

hisuwh commented Jan 26, 2022

Describe the bug
Setting the form to a loading state if returning a promise from the submit handler is a great new feature.

I believe the inputs should be disabled whilst in this loading state.
Currently, this is not the case meaning you can edit existing inputs whilst the submit button is "spinning".

Reproduction
https://formkit.link/a03e7b8b648463917105d9f75928b748

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 97.0.4692.71
@justin-schroeder
Copy link
Member

👋 Interesting. This is a subjective slippery slope for sure, one that we admittedly tiptoed into by adding that automatically added submit button 😂

I'll leave this open to collect more community feedback on this. In the meantime, here's how you can do it today:

https://formkit.link/9a645bcc332ee42b51c09b8a8f0c1928

@justin-schroeder justin-schroeder added 🪄 enhancement New feature or request 🚀 release-ready Feature or fix is complete and on an upcoming release branch labels Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement New feature or request 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Development

No branches or pull requests

2 participants