Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker invalidDate validation rule key can't set custom validation message #953

Closed
KoenCa opened this issue Sep 19, 2023 · 3 comments
Closed
Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch

Comments

@KoenCa KoenCa added ⛑ Needs triage The issue has not yet been examined by the FormKit team. 🐛 bug-report Bug is reported, but not verified by team labels Sep 19, 2023
@KoenCa
Copy link
Author

KoenCa commented Sep 19, 2023

I wanted to do this, because this validation message is not translated in my message, but when I take a look at the nl.ts translation file, then I see that it is translated:

invalidDate: 'De geselecteerde datum is ongeldig.',

So it looks like the translation is also not picked up for this key?

@justin-schroeder justin-schroeder added 🐛 bug Verified bug by team and removed 🐛 bug-report Bug is reported, but not verified by team ⛑ Needs triage The issue has not yet been examined by the FormKit team. labels Dec 1, 2023
@justin-schroeder
Copy link
Member

Ah, invalidDate is under the ui key not the validation key in our i18n files, but the message type is validation. This is my fault and will be fixed in 1.3.3.

@justin-schroeder justin-schroeder added the 🚀 release-ready Feature or fix is complete and on an upcoming release branch label Dec 1, 2023
@justin-schroeder
Copy link
Member

Resolved in 1.4.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Verified bug by team 🚀 release-ready Feature or fix is complete and on an upcoming release branch
Projects
None yet
Development

No branches or pull requests

2 participants