Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: angular-material-lite #53

Merged
merged 1 commit into from
Jul 15, 2015
Merged

Conversation

benoror
Copy link
Member

@benoror benoror commented Jul 15, 2015

example: material design lite (http://jsbin.com/bujuwi)

material design lite
@kentcdodds
Copy link
Member

Way cool! Looks like there are a few things that aren't bound to the model though, is that intentional?

@kentcdodds
Copy link
Member

Specifically, I noticed gender and expensive weren't bound.

@benoror
Copy link
Member Author

benoror commented Jul 15, 2015

Oops sorry, corrected 😄

@kentcdodds
Copy link
Member

If you're interested in contributing to a full-on library, please comment here

Note, the angular-formly-templates-material is specifically supposed to integrate with the official angular-material library. We could create an angular-formly-templates-material-lite template library though. Do you want me to create a shell for that so you can link to that one instead?

@benoror
Copy link
Member Author

benoror commented Jul 15, 2015

That would be cool!. Although honestly I don't think I will be able to contribute significantly in the near term.

Maybe we can convince @jadjoubran (angular-material-design-lite maintainer) to help, as it could potentially be a cool project to expose his library, launch it into the stratosphere thanks to angular-formly. ✌(◕‿-)✌

kentcdodds pushed a commit that referenced this pull request Jul 15, 2015
example: angular-material-lite
@kentcdodds kentcdodds merged commit c0226d0 into formly-js:master Jul 15, 2015
@kentcdodds
Copy link
Member

👍

@jadjoubran
Copy link

thanks @benoror!
of course I'd be interested
How can we get started?

@benoror
Copy link
Member Author

benoror commented Jul 15, 2015

Cool! Maybe @kentcdodds can help us out making a shell repo first.

First you should learn more about this awesome library: https://github.com/formly-js/angular-formly#bookmark-links

Finally you might re-use some logic from this early implementation for angular-material: https://github.com/formly-js/angular-formly-templates-material

@kentcdodds
Copy link
Member

@jadjoubran, I've created a shell repo and added you as an admin on it. I recommend you look at @benoror's example (just published) and basically do the same thing only in a separate module. You can look at the bootstrap templates for an example.

@benoror
Copy link
Member Author

benoror commented Jul 15, 2015

Thanks @kentcdodds !

Also updated the jsbin's description link (formly-js/angular-formly-templates-material-lite#1)

Kudos @jadjoubran !

@jadjoubran
Copy link

great thanks!
Is there any documentaiton on what the shell repo is? It's the first time I hear about formly but I get the idea.
And another quesiton, the shell is going to be on top of angular-material-design-lite?

@kentcdodds
Copy link
Member

So, basically, you own the repo: https://github.com/formly-js/angular-formly-templates-material-lite

You could take @benoror's example and create an angular module that does the same kind of thing (with the formlyConfig provider) and export that module as part of your library. You'll pretty much be doing the same thing as in: https://github.com/formly-js/angular-formly-templates-bootstrap

But how you build it is entirely up to you. You can use grunt/gulp/webpack whatever.

If you want a good starting point, I recommend you watch all the (free) egghead.io lessons here: http://learn.angular-formly.com

@jadjoubran
Copy link

that's great, thanks! I should probably push something by the weekend

@kentcdodds
Copy link
Member

Awesome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants