Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jest to v29 #37

Merged
merged 33 commits into from Jun 23, 2023
Merged

chore: upgrade jest to v29 #37

merged 33 commits into from Jun 23, 2023

Conversation

bhongy
Copy link
Contributor

@bhongy bhongy commented Jun 20, 2023

Changes

  • Upgrade jest to v29 (from v26) and upgrade its related dependencies (e.g. babel)
  • Centralize jest and its related dependencies to workspace root for version consistency
  • Run test Turbo task (which runs jest) in CI

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

🦋 Changeset detected

Latest commit: f77d985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@formspree/react Patch
@formspree/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formspree-react-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 5:19am

"eslint": "^8.15.0",
"husky": "^8.0.0",
"jest": "^29.5.0",
"jest-environment-jsdom": "^29.5.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required as a separate package since Jest 28
https://jestjs.io/docs/28.x/upgrading-to-jest28#jsdom

Comment on lines -9 to -12
"test": {
"outputs": ["coverage/**"],
"dependsOn": []
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove empty dependsOn.

We don't run test task to produce coverage. If we want to support running test with coverage artifacts, we should create a separate test:coverage task that outputs to "coverage/**".

packages/formspree-react/package.json Show resolved Hide resolved
@@ -37,16 +37,12 @@
"@stripe/stripe-js": "^1.35.0"
},
"devDependencies": {
"@babel/core": "^7.22.1",
"@swc/core": "^1.3.61",
"@babel/preset-react": "^7.22.5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it local since this is the only package that needs it.

"@babel/preset-typescript",
"@babel/preset-react"
],
"plugins": ["@babel/plugin-transform-runtime"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need

"typecheck": "turbo run typecheck",
"version-packages": "changeset version"
},
"devDependencies": {
"@babel/core": "^7.22.5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peer dependency of babel-jest

Base automatically changed from chore/manage-typescript-at-root to main June 22, 2023 04:14
@bhongy bhongy merged commit a359edd into main Jun 23, 2023
3 checks passed
@bhongy bhongy deleted the chore/upgrade-to-jest-29 branch June 23, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants