New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade jest to v29 #37
Conversation
This reverts commit 82138ad.
🦋 Changeset detectedLatest commit: f77d985 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"eslint": "^8.15.0", | ||
"husky": "^8.0.0", | ||
"jest": "^29.5.0", | ||
"jest-environment-jsdom": "^29.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required as a separate package since Jest 28
https://jestjs.io/docs/28.x/upgrading-to-jest28#jsdom
"test": { | ||
"outputs": ["coverage/**"], | ||
"dependsOn": [] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove empty dependsOn
.
We don't run test
task to produce coverage. If we want to support running test with coverage artifacts, we should create a separate test:coverage
task that outputs to "coverage/**"
.
@@ -37,16 +37,12 @@ | |||
"@stripe/stripe-js": "^1.35.0" | |||
}, | |||
"devDependencies": { | |||
"@babel/core": "^7.22.1", | |||
"@swc/core": "^1.3.61", | |||
"@babel/preset-react": "^7.22.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it local since this is the only package that needs it.
"@babel/preset-typescript", | ||
"@babel/preset-react" | ||
], | ||
"plugins": ["@babel/plugin-transform-runtime"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need
"typecheck": "turbo run typecheck", | ||
"version-packages": "changeset version" | ||
}, | ||
"devDependencies": { | ||
"@babel/core": "^7.22.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peer dependency of babel-jest
cd34305
to
ad84a1a
Compare
3b32c8c
to
6aab2cf
Compare
58cb26c
to
d937ea7
Compare
d937ea7
to
e26009e
Compare
9458784
to
ff27d6b
Compare
Changes
test
Turbo task (which runs jest) in CI