Fix issue where clicking on span in option would not update value. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ var FormComponentMixin = { | |||
| }, | |||
|
|
|||
| handleChange: function handleChange(event) { | |||
| this.setValue(event.currentTarget.value); | |||
| this.setValue(event.target.value); | |||
There was a problem hiding this comment.
Instead of changing the mixin itself(which would affect the handleChange for all components). Shouldn't we have this code for formsy-select only?
There was a problem hiding this comment.
I didn't see problems with FormsyText (the only other field that uses the method) when I was at 0.2.2. However it looks like you might be splitting out the handleChange functionality with your new PR to fix 0.2.3, so I'm not sure this fix will still apply if/when that happens.
|
Ref: #4 |
mbrookes
pushed a commit
that referenced
this pull request
Nov 1, 2015
Fix issue where clicking on span in option would not update value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.