Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for material-ui v0.16 in peerDepencencies #160

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

joelkoz
Copy link
Collaborator

@joelkoz joelkoz commented Nov 16, 2016

Material-UI version is required in both peerDependencies and
devDependencies.

Material-UI version is required in both peerDependencies and
devDependencies.
@ryanblakeley
Copy link
Collaborator

The integration test failed. How can we make it pass? Does material-ui need to be included in both peerDependecies and devDependencies?

@joelkoz
Copy link
Collaborator Author

joelkoz commented Nov 16, 2016

The test fails on the current 0.5.2 release also. The PR that fixes the validation issue needs to be applied also to get it to pass.

-jk
(sent from my iPhone)

On Nov 16, 2016, at 4:07 PM, Ryan B. Blakeley notifications@github.com wrote:

The integration test failed. How can we make it pass? Does material-ui need to be included in both peerDependecies and devDependencies?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@joelkoz
Copy link
Collaborator Author

joelkoz commented Nov 17, 2016

Re: being in peerDependencies AND devDependencies: I don't know if it needs to be in both places or not, but the current 0.5.2 release has them in both places, so I didn't think I should change that.

@ryanblakeley ryanblakeley merged commit aaf3cc2 into formsy:master Nov 17, 2016
@crashbell
Copy link
Contributor

Thank you @joelkoz @rojobuffalo
I hope that this change can be published soon since we are stuck upgrading material-ui due to peerDep.

@ryanblakeley
Copy link
Collaborator

As mentioned in #152, if you pull down the HEAD of the master branch and confirm that everything is working--I'm happy to publish v0.5.3. I think it's ready, but just want some confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants