New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make example compatible with react 15.4.x #187

Merged

ryanblakeley merged 1 commit into formsy:master from kouak:react-15.4

Jan 30, 2017

Contributor

kouak commented Jan 7, 2017

The example provided is currently broken.

ERROR in ./~/react-tap-event-plugin/src/injectTapEventPlugin.js
Module not found: Error: Cannot resolve module 'react/lib/EventPluginHub' in /home/kouak/Dev/formsy-material-ui/examples/webpack-example/node_modules/react-tap-event-plugin/src
 @ ./~/react-tap-event-plugin/src/injectTapEventPlugin.js 23:2-37

What happens is that the react semver range selected in the example (^15.0.1) will download react 15.4.2 and react-tap-event-plugin 1.0.0.

React 15.4.2 is not compatible with react-tap-event-plugin 1.0.0, breaking the build.

This PR bumps 3 dependency versions :

Material-ui to ^0.16.0
react & react-dom to ^15.4.0
react-tap-event-plugin to ^2.0.1 (compatible with react 15.4).


          Make example compatible with react 15.4.x

600210d

ryanblakeley merged commit 1cb6368 into formsy:master

ryanblakeley mentioned this pull request

ERROR during build in examples #189

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment