Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #174 and re-apply interim changes #192

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Revert #174 and re-apply interim changes #192

merged 1 commit into from
Feb 9, 2017

Conversation

ryanblakeley
Copy link
Collaborator

@codeaholicguy hey, would you mind giving this a quick review?

@codeaholicguy
Copy link
Collaborator

LGTM

@codeaholicguy
Copy link
Collaborator

@rojobuffalo Should fix linter before merging

@ryanblakeley
Copy link
Collaborator Author

It's a false positive from the linter: see related issue. A comma after ...rest is a syntax error, so our eslint rule comma-dangle: ["error", "always-multiline"] is supposed to allow there not to be a comma in this special case.

I see 3 options:

  1. Let it through with an error reporting a false positive.
  2. Try upgrading babel-eslint.
  3. Temporarily disable the eslint rule or inline disable

@codeaholicguy
Copy link
Collaborator

I think update .eslintrc is the best way to do this

@ryanblakeley
Copy link
Collaborator Author

Turns out putting the } = this.props on the same line with ...rest silences the error. This is sort of letting the tail wag the dog, but whatever.

@ryanblakeley ryanblakeley merged commit aca33b4 into formsy:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants