added errorText to FormsySelect #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Michael, yes several MUI components didn't support errorText in the React 13.x compatible version, so I removed them from FMUI as I wasn't in a position to test with React 14.x. Happy to see these added back in now that React 14 is officially supported by material-ui, formsy-react, and in my case, Meteor. |
mbrookes
added a commit
that referenced
this pull request
Nov 3, 2015
added errorText to FormsySelect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbrookes this PR just adds the errorText prop to FormsySelect. There are other components, like RadioGroup that may need an errorText prop too. But I think it's safer to look at those separately from this PR.