Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormsySelect] Add support for composable SelectField #41

Merged
merged 1 commit into from Jan 11, 2016
Merged

[FormsySelect] Add support for composable SelectField #41

merged 1 commit into from Jan 11, 2016

Conversation

ryanblakeley
Copy link
Collaborator

fix #40
Fixes issues with DropDownMenu where it wants MenuItems passed as children (composability).

handleChange reflects updates to the material-ui API. It takes (event, index, value) so we can directly access the value, rather than going through event.target.value.

It adds a state variable hasChanged for deciding whether to pass the initial props.value (there is no unique initialValue prop) or the formsy mixin method this.getValue().

@ryanblakeley ryanblakeley changed the title fix #40 Fix FormsySelect Jan 11, 2016
@mbrookes
Copy link
Collaborator

Thank you very much @rblakeley, that's great! 👍 Please could you squash / fixup, then I can merge.

You can leave out the prepubs - I'll push that as part of the version bump.

@ryanblakeley
Copy link
Collaborator Author

No worries. I was running into the same issue in my app.

It's squashed now.

@mbrookes mbrookes changed the title Fix FormsySelect [FormsySelect] Add support for composable SelectField Jan 11, 2016
mbrookes added a commit that referenced this pull request Jan 11, 2016
[FormsySelect] Add support for composable SelectField
@mbrookes mbrookes merged commit 6f564d9 into formsy:master Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormsySelect] "menuItems" property of "SelectField" and "DropDownMenu" has been deprecated
2 participants