Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc4 broken with rails 3.1.0.rc4/rc5 #657

Closed
gucki opened this issue Aug 18, 2011 · 6 comments
Closed

rc4 broken with rails 3.1.0.rc4/rc5 #657

gucki opened this issue Aug 18, 2011 · 6 comments
Milestone
2.0.0.rc5

Comments

@gucki
Copy link
Contributor

gucki commented Aug 18, 2011

rc3 works, with rc4 I get

undefined method `perform_browser_validations'

at

formtastic (2.0.0.rc4) lib/formtastic/helpers/form_helper.rb:146:in `semantic_form_for'
@sobrinho
Copy link
Member

Cold you check with 3.1.0.rc6?

@gucki
Copy link
Contributor Author

gucki commented Aug 18, 2011

Same with 3.1.0.rc6 for me..

@sobrinho
Copy link
Member

Could you check with master branch of formtastic too?

@gucki
Copy link
Contributor Author

gucki commented Aug 18, 2011

There are no commits since 2.0.0.rc4?
2.0.0.rc4...master

@gucki
Copy link
Contributor Author

gucki commented Aug 18, 2011

Ok, I just found out the exception is only thrown when also using the "navigasmic" gem. So I'm not sure if this is bug in navigasmic or formtastic..? https://github.com/jejacks0n/navigasmic

@gucki
Copy link
Contributor Author

gucki commented Aug 18, 2011

@sobrinho: fix is here #658 :)

@gucki gucki closed this as completed Aug 18, 2011
sobrinho added a commit that referenced this issue Aug 18, 2011
@sobrinho
Merge pull request #658 from gucki/master
a95479e 
Fix for #657, rc4 broken with rails 3.1.0.rc4/rc5 (now really navigasmic)
sobrinho added a commit that referenced this issue Aug 19, 2011
@sobrinho
Spec for issue #657 to avoid regression
c64f967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0.rc5
Development

No branches or pull requests
2 participants
@sobrinho @gucki