FormGenerator is Back! (should close #717)

[jcorcuera]

It is based on the old FormGenerator and keeps the same configuration options.

[justinfrench]

Excellent! When you say "based on", how much has it changed? Have you tested in both a Rails 3 and 3.1 app for completeness?

[jcorcuera]

Yes it is tested in both Rails 3 and 3.1

The main changes compared with the old generator are:

• Remove the --partial option, because it always generates a partial unless --copy option is set.
• By default it uses the defined template engine on the application.
• Add --template-engine option with support for ERB, HAML and SLIM. The old one only has the --haml option to render HAML template instead of ERB.
• It keeps the --copy and --controller options.
• About the model attributes:
  ** It takes the content columns and skips the columns defined in Formtastic::Helpers::InputsHelper::SKIPPED_COLUMNS like updated_at, created_at, etc.
  ** It only takes the belongs_to associations and skips if they are polymorphic because we can't guess which class to use for an automatically generated input.
• It uses the templates already defined on /lib/generators/templates.

[justinfrench]

Excellent work! So it's probably only the --template-engine option that needs to be documented. I can easily do that after I merge this in. Will do soon.

[jcorcuera]

@justinfrench i just noticed something on the defined templates /lib/generators/templates it works ok for ERB but for HAML and SLIM it renders 4 spaces instead of two:

= semantic_form_for @post do |f|
  = f.inputs do
      = f.input :title    # 4 spaces
      = f.input :author # 4 spaces

  = f.buttons do
    = f.commit_button

I can fix them on this pull request too, what do you think?

[justinfrench]

@jcorcuera yes please, make it as awesome as you can :)

[jcorcuera]

Ok @justinfrench it's done!

One thing to keep in mind about the templates, they were already used by the formtastic:install generator so the users who run this generator (all users) have the wrong templates because they were copied to "lib/templates/#{engine}/scaffold/_form.html.#{engine}".

[justinfrench]

@jcorcuera Urgh, I didn't realise we were copying stuff into the app. How is copy_scaffold_template called — can't see it in our code, so is Rails calling it? Any suggestions on making this less sucky?

[justinfrench]

@jcorcuera The lib stuff is probably out of scope, so if you're happy with the work you've done, I'll merge it in.

[jcorcuera]

Hi @justinfrench, The work about Form Generator is ok. The Install Generator is another issue, maybe we should open a new one.

[justinfrench]

@jcorcuera please do add one, will merge this one in now, thanks.