Extension host freezing when trying to rename tag with space on the end

[AlexanderArvidsson]

If you try to edit a tag that happens to have a space before the >, it will freeze the entire extension host and stop working completely. It will also increase CPU usage significantly. I assume there's an infinite loop going on somewhere?

Try creating an empty html file with these contents:

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24">
  <path d="M12 0c-6.627 0-12 5.373-12 12s5.373 12 12 12 12-5.373 12-12-5.373-12-12-12zm3 8h-1.35c-.538 0-.65.221-.65.778v1.222h2l-.209 2h-1.791v7h-3v-7h-2v-2h2v-2.308c0-1.769.931-2.692 3.029-2.692h1.971v3z" />
</svg>

Then try editing the path tag. The extension host will freeze. This happens regardless if you use /> or ></path>, as long as there is a space before.

[formulahendry]

Could not repro in my side. Could you please disable all other extensions and try again? And then, disable this extension and try again?

[AlexanderArvidsson]

@formulahendry, I did disable all my extensions. I have even tried debugging the extension by forking the project and was planning on creating a pull request if I managed to fix it, but didn't come up with anything. This happens for me in both the insiders build and the stable release.
It also happens on both my laptop and my desktop pc. Laptop is running Windows 10 and desktop running windows 8.1.

[AlexanderArvidsson]

It's important to notice that when I say "the extension host will freeze", I don't mean the application freezes, but the extension HOST freezes. You can still type and do stuff in the application, but all extensions will break. Check your task manager and you will notice that visual studio code will take up a lot of CPU usage after you do what I described in the first post.

Here's a video showing the problem

[formulahendry]

Got it! Thanks for the detailed info! I will take a look when I have time. If you have any findings to fix it, PR is very welcome!