Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update callback function parameter types to use uint16_t instead of uint8_t. #126

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

forntoh
Copy link
Owner

@forntoh forntoh commented Aug 9, 2023

  • Changed the parameter type of toggleBacklight function in Callbacks.ino from uint8_t to uint16_t.
  • Changed the parameter type of callback function in IntFloatValues.ino from uint8_t to uint16_t.
  • Changed the parameter types of colorsCallback and numsCallback functions in List.ino from uint8_t to uint16_t.
  • Updated the typedefs in Constants.h for callback functions with integer parameters.
  • Updated the return types of getItemIndex() functions in ItemList.h and ItemProgress.h classes from uint8_t to uint16_t.

This commit updates callback function parameter types and related definitions.

fixes #125

… `uint8_t`.

- Changed the parameter type of `toggleBacklight` function in `Callbacks.ino` from `uint8_t` to `uint16_t`.
- Changed the parameter type of `callback` function in `IntFloatValues.ino` from `uint8_t` to `uint16_t`.
- Changed the parameter types of `colorsCallback` and `numsCallback` functions in `List.ino` from `uint8_t` to `uint16_t`.
- Updated the typedefs in Constants.h for callback functions with integer parameters.
- Updated the return types of getItemIndex() functions in ItemList.h and ItemProgress.h classes from uint8_t to uint16_t.

This commit updates callback function parameter types and related definitions.
@forntoh forntoh changed the title 125 ITEM_PROGRESS callback input parameter overflows Update callback function parameter types to use uint16_t instead of uint8_t. Aug 9, 2023
@forntoh forntoh marked this pull request as ready for review August 9, 2023 04:08
@forntoh forntoh merged commit a88fcdc into master Aug 9, 2023
11 checks passed
@forntoh forntoh deleted the 125-item_progress-callback-input-paramet branch August 9, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITEM_PROGRESS callback input parameter overflows
1 participant