remove template functionality in condition builder

forrert · Apr 9, 2017 · 605e5f6 · 605e5f6
1 parent fa9a66f
commit 605e5f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/lib/conditionbuilder.js b/lib/conditionbuilder.js
@@ -4,10 +4,6 @@ var _ = require('lodash'),
     promise = require('promise'),
     util = require('./util.js');
 
-var templateOptions = {
-    interpolate: /{{([\s\S]+?)}}/g
-};
-
 var getParameters = function(modelProviders, target) {
     var parameters = {target: target};
     _.reduce(modelProviders, function(parameters, modelProvider) {
@@ -62,9 +58,6 @@ ConditionBuilder.prototype.getPromise = function() {
         return getRulesPromise(this.securityManager, parameters, this.rules)
             .then(function(conditions) {
                 return domain.aggregateConditions(conditions);
-            }).then(function(condition) {
-                var template = JSON.stringify(condition);
-                return JSON.parse(_.template(template, templateOptions)(parameters));
             });
     } else {
         return util.promisify(domain.aggregateConditions([]));

diff --git a/test/policy.test.js b/test/policy.test.js
@@ -201,22 +201,22 @@ describe('Policy Spec:', function() {
             aRule = {userId: '{{userId}}'},
             anotherRule = {date: {$gt: '{{today}}'}};
 
-        it('replaces a parameter in rule', function(done) {
+        xit('replaces a parameter in rule', function(done) {
             var policy = new policyCtor([aModelProvider], securityManager);
             policy.addRule(aModel, aPermission, aRule);
             var condition = policy.getCondition(aModel, aPermission);
 
             assertCondition(condition, {userId: 'joe'}, done);
         });
-        it('replaces multiple parameters in rules', function(done) {
+        xit('replaces multiple parameters in rules', function(done) {
             var policy = new policyCtor([aModelProvider, anotherModelProvider], securityManager);
             policy.addRule(aModel, aPermission, aRule);
             policy.addRule(aModel, aPermission, anotherRule);
             var condition = policy.getCondition(aModel, aPermission);
 
             assertCondition(condition, {$or: [{userId: aUserId}, {date: {$gt: aDate}}]}, done);
         });
-        it('throws an exception if a parameter is absent', function(done) {
+        xit('throws an exception if a parameter is absent', function(done) {
             var policy = new policyCtor([aModelProvider], securityManager);
             var aRuleWithAbsentParameter = {userId: '{{adminId}}'};