Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Improve the Violation Identifier Fix (1.0) #1002

Merged
merged 2 commits into from Jan 25, 2018
Merged

Conversation

blueandgold
Copy link
Contributor

This moves the setting of the resource_id more upstream to where the violation is actually being created.

This is for 1.0.

@blueandgold blueandgold changed the title Improve the Violation Identifier Fix Improve the Violation Identifier Fix (1.0) Jan 25, 2018
@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #1002 into dev will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             dev    #1002      +/-   ##
=========================================
- Coverage   83.3%   83.29%   -0.02%     
=========================================
  Files        163      163              
  Lines       7831     7832       +1     
=========================================
  Hits        6524     6524              
- Misses      1307     1308       +1
Impacted Files Coverage Δ
...ud/security/scanner/audit/bigquery_rules_engine.py 94.18% <ø> (ø) ⬆️
...ud/security/scanner/audit/cloudsql_rules_engine.py 65.38% <ø> (ø) ⬆️
...r/audit/instance_network_interface_rules_engine.py 92.53% <ø> (ø) ⬆️
...oud/security/scanner/audit/buckets_rules_engine.py 81.48% <ø> (ø) ⬆️
...ecurity/scanner/scanners/cloudsql_rules_scanner.py 39.21% <ø> (ø) ⬆️
...ner/scanners/instance_network_interface_scanner.py 0% <ø> (ø) ⬆️
...loud/security/scanner/scanners/bigquery_scanner.py 37.03% <ø> (ø) ⬆️
.../security/scanner/scanners/bucket_rules_scanner.py 37.03% <0%> (-0.7%) ⬇️

@blueandgold blueandgold merged commit 01510a6 into dev Jan 25, 2018
@blueandgold blueandgold deleted the improveviolationfix branch January 25, 2018 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants