Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Adding initial table schema for GSuite groups. #159

Merged
merged 2 commits into from Mar 28, 2017
Merged

Adding initial table schema for GSuite groups. #159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b2da48
Adding initial table schema for GSuite groups.
mirons-google Mar 28, 2017
ef5251c
Merge branch 'master' into groups
mirons-google Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions google/cloud/security/common/data_access/sql_queries/create_tables.py
View file
Open in desktop
Expand Up @@ -73,3 +73,12 @@
PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
"""

CREATE_GSUITE_ACCOUNT_GROUPS_TABLE = """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits here:
(1) can we avoid using "ACCOUNT" here? and just leave this as CREATE_GSUITE_GROUPS_TABLE ?
(2) can we make this more generic, i.e not use "GSUITE"? as to avoid any fallout from name changes in the future? and also to make this more platform neutral?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I put some thought into this too.

Currently the API is defined here as the Directory API. When fetching groups you can scope the request to an account, a domain, or a sub-domain. Since it's my intention to specify account in the request I felt it appropriate to name the table with the same scope.

As it relates to GSuite I'm open to other ideas.

There could conceivably be other "groups" objects put out by other product teams I suspect scoping this to what it is (currently) gsuite made sense.

CREATE TABLE `{0}` (
`id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other attributes we like to save? i.e. "name"

BTW, what is the resource description for the group response? is there a link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response

Right now I'm just collecting group_id and group_email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the groups resource definition, the "alias" might be interesting:
https://developers.google.com/admin-sdk/directory/v1/reference/groups#resource

Do you think that we would need aliases? Could aliases be used somehow in permissioning? If so, it would help to collect it.

`group_id` varchar(255) DEFAULT NULL,
`group_email` varchar(255) DEFAULT NULL,
PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
"""