Add regtest support #249
Merged
Add regtest support #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarvstedt
force-pushed
the
regtest
branch
4 times, most recently
from
b2c1a52
to
08adb5c
Compare
Remove unsupported option 'testnet'.
bind-addr can't be null.
Enables lightning-cli group access when nonstandard config options are set.
Also: - quote paths - use long form args
Also set bitcoind rpc port.
Needed for regtest scenario.
Needed for regtest scenario.
|
Rebased to master. |
|
ACK. This is excellent! Feeling a bit useless because I have nothing to complain about.
Yeah generally that seems better but can be different PR. |
|
Ah, |
jonasnick
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regtest allows testing services in a synced-blockchain scenario.
Run the test via
test/run-tests.sh -s regtest.Besides enabling in-depth service testing, this is also a great consistency check for our service modules. The number of service bugfixes included in this PR is testament to this.
regtestrevealed that lightning-loop always requiresserver.hostto be set. Should we add an option for it?