Improve examples #250
Merged
Improve examples #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'echo sudo' approach used previously failed when PATH or NIX_PATH contains spaces. Exec the script with sudo instead.
|
On Debian It might also have to be run with sudo. |
nixbitcoin
reviewed
Oct 19, 2020
examples/minimal-configuration.nix
Outdated
| { config, pkgs, lib, ... }: { | ||
| imports = [ | ||
| <nix-bitcoin/modules/nix-bitcoin.nix> | ||
| <nix-bitcoin/modules/generate-secrets.nix> |
There was a problem hiding this comment.
Shouldn't this be <nix-bitcoin/modules/secrets/generate-secrets.nix>? I'm getting
error: file 'nix-bitcoin/modules/generate-secrets.nix' was not found in the Nix search path (add it using $NIX_PATH or -I), at /home/nix-bitcoin/nix-bitcoin/examples/minimal-configuration.nix:4:5
There was a problem hiding this comment.
Thanks, this was an untested last-minute change. Fixed.
erikarvstedt
force-pushed
the
examples
branch
from
cfee211
to
af17c08
Compare
|
The |
erikarvstedt
force-pushed
the
examples
branch
2 times, most recently
from
0bb5fe5
to
c1df4cb
Compare
erikarvstedt
force-pushed
the
examples
branch
from
c1df4cb
to
5d32218
Compare
jonasnick
previously approved these changes
Oct 20, 2020
erikarvstedt
force-pushed
the
examples
branch
from
5d32218
to
8fe638c
Compare
nixbitcoin
reviewed
Oct 20, 2020
examples/deploy-container.sh
Outdated
| exec nix-shell --run "./${BASH_SOURCE[0]##*/} $*" | ||
| fi | ||
|
|
||
| if [[ $(sysctl -n net.ipv4.ip_forward || sudo sysctl -n net.ipv4.ip_forward) != 1) ]]; then |
erikarvstedt
force-pushed
the
examples
branch
from
8fe638c
to
b574cb0
Compare
nixbitcoin
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK b574cb097f27e82fdcfa39b5705855993a600464
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEV3o0Un8+KoXoD+Fk3RH5rVMIs7oFAl+OwA0ACgkQ3RH5rVMI
s7qEaxAAzHrwuL4n19ncL9nAh1Zg9wC6QYUGWHFJ7O1Lc/SE24c8DdyJpikMbDBe
EuaFiCXDscy2rl60md56HESjRteJJQDnrXCNKL3hGodWbwtzIACYH4N1W8+XoqUI
Sc/QFoE5p16Zr2AOAdwspRVfn6SMsC0cxety47HzpMcxL+LJGtWom5eBcZzF8UCd
t5rMMYLdJ1s6ruZlJpY06FtasDztHbGkbim8zM7SVqVIQftvNAYmzq53q4FGPM27
7+s9KtzdAGF3EmGJRL+wgxLvydzlCgoscYJzaOEPym2CK7jdtpB4qftxXTCrKbeR
RfNeGBzGk9EC+QX5ak4VyQrdz9e1VtxecrMH0ekxhFfxsNNlhJK0OZMuzQSO3p8F
xQXUG+LC4DEZB9W538tYn4BcxYuIGDuRo6kO1OWWv4cUyMdWlj3a4sBIE1x3fZ9z
siOvMJAVt20CvP9ttVtgKHRxiLSntKLLdtvHzztshOebDyRs4ANXGThy+7/QwK9M
M8aDmb2CvXQBupzQldY1unmPM3I+ETBjGbEQLEqHzlH4ZDb69A3aYdQwgMNySguN
LbrHw7SRgXRBT8fUi1jDIWz7D1ATdJlZKxsr0f503GdYk7+m+fvFGpfeRxwrcD7l
r0eA8aMpS23DQu/heHxIkk+/SGJBRYc6dZiYiBHWC5J3aigk9x0=
=ZTyn
-----END PGP SIGNATURE-----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.