Fix containers for nixpkgs 20.09 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These packages are not useful in shell environemnts.
This works around a nixpkgs bug where overlays are ignored in containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nixpkgs 20.09 introduced a bug where nixpkgs overlays are ignored in containers. This breaks our
pkgs.nix-bitcoinoverlay:$ test/run-tests.sh container error: attribute 'nix-bitcoin' missing, at /home/main/d/nix-bitcoin/src/modules/bitcoind.nix:62:19My upstream bugfix PR has not been merged yet.
Work around this by providing nix-bitcoin pkgs via an option instead of an overlay (in
modules.nix).This also has the advantage to slightly speed-up container builds because the
pkgsof the host system can be reused in the container.