Lightning pool #313

sputn1ck · 2021-02-01T16:43:36Z

This PR integrates lightning-pool to nix-bitcoin. Lightning Pool is a non-custodial batched uniform clearing-price auction for Lightning Channel Leases (LCL). An LCL packages up inbound channel liquidity (ability to receive funds) as a fixed income asset with a maturity date expressed in blocks.

I'm pretty novice at nixos, so it's better if you take a closer look 😄

Details

The tls certificate and key can't be in the /secrets/ folder as the --basedir arg overwrites --tlscertpath
The conf file needs to be written in the basedir folder, I don't know if the chmod and chown I did was right
It requires the uptime bitcoind rpc call
It requires a publicly reachable uri, I tried setting nix-bitcoin.onionServices.lnd.public=true; in the module itself, however it led to error: infinite recursion encountered, which is why I added the assertion
Tested with a succesful account and order creation

erikarvstedt · 2021-02-01T23:40:01Z

which is why I added the assertion

That's the preferred solution anyways, because users shouldn't be forced to use tor for public addresses. They can also manually define getPublicAddressCmd instead.

Can you add a test? (See tests.nix, tests.py)

Kixunil · 2021-02-02T09:35:31Z

FYI a change to pool just got merged that allows you to specify a single macaroon instead of the whole directory. So the next release should have it. Using it may be a better design if you decide to move macaroons in the future (e.g. to put them in differently-protected directories).

nixbitcoin · 2021-02-02T13:26:04Z

pkgs/lightning-pool/get-sha256.sh

+echo "Fetching latest release"
+git clone https://github.com/lightninglabs/pool 2> /dev/null
+cd pool
+latest=v0.4.3-alpha


Is there a reason why you're not using the "latest release" logic from the other get-sha256 scripts?

I think lightning labs did something wrong with their tagging. If i use the other logic i get the auctioneerrpc/v1.0.1 tag

The failure results from multiple tags being on the same commit. Let's use the default logic on the next tag, which will hopefully be the only one on that commit.

sputn1ck · 2021-02-02T13:29:27Z

Can you add a test? (See tests.nix, tests.py)

Just added the tests similiar to those of lightning-loop

nixbitcoin · 2021-02-02T15:31:06Z

Fixups

Great work @sputn1ck! The only thing that annoys me is that there is no proxy option to connect to auction servers over Tor. Should we open an issue upstream?

EDIT: Issue opened lightninglabs/pool#215

sputn1ck · 2021-02-03T11:11:40Z

Fixups

I rebased to the current master and included your fixups

nixbitcoin · 2021-02-03T11:39:06Z

Only two very minor fixups I missed during my review, then I'm ready to ACK

nixbitcoin

jonasnick

I really don't like that this module leaks your ip address to the pool server. We either need to document this clearly, use iptables to route through tor ("transparent proxy") or wait until pool has a proxy option.

sputn1ck · 2021-02-03T13:10:23Z

examples/configuration.nix

+  # clearing-price auction for Lightning Channel Leases. pool (lightning-pool
+  # daemon) will be started automatically. Users can interact with it using
+  # `pool`.
+  # Privacy Warning: Lightning-pool currently connects to the


Would a warning here be enough?

sputn1ck · 2021-02-03T13:51:15Z

I really don't like that this module leaks your ip address to the pool server. We either need to document this clearly, use iptables to route through tor ("transparent proxy") or wait until pool has a proxy option.

I opened a PR upstream lightninglabs/pool#216 which works on my nix-bitcoin branch

nixbitcoin · 2021-02-03T14:13:56Z

Don't forget to add lightning-pool to the README.md

erikarvstedt · 2021-02-03T17:19:53Z

Fixups.

Does loop require that lnd announces its address via externalip? Or is public reachability sufficient?

Please squash the test commit into the other commit that contains the corresponding functional changes (rationale).

sputn1ck · 2021-02-03T19:33:39Z

Does loop require that lnd announces its address via externalip? Or is public reachability sufficient?

https://github.com/lightninglabs/pool/blob/41d958e284f6c9c25239e06263454d010a6633b7/order/manager.go#L165

// If the order is a ask, then this means they should be an effective
// routing node, so we require them to have at least a single
// advertised address.
if len(nodeAddrs) == 0 && order.Type() == TypeAsk {
    return nil, fmt.Errorf("the lnd node must " +
	    "be reachable on clearnet to negotiate channel " +
	    "ask order")
}

afaiu it requires it via externalip

erikarvstedt · 2021-02-03T20:37:26Z

lnd has other ways like this for setting the external ip, so I'd recommend to remove the getPublicAddressCmd assertion.

sputn1ck · 2021-02-05T10:02:01Z

lightninglabs/pool#216 has been merged, should we wait for a new release?

lnd has other ways like this for setting the external ip, so I'd recommend to remove the getPublicAddressCmd assertion.

Should the information of public addresses be added to the example/configuration.nix ?

erikarvstedt · 2021-02-05T10:03:43Z

I'm fine with using the unreleased version.

Should the information...

Yes, great idea!

jonasnick · 2021-02-05T12:45:54Z

I'd try to avoid running unreleased versions wherever possible. We can wait for a new pool release or document the privacy implications of the current version in configuration.nix and remove them as soon as we update to the new release.

Kixunil · 2021-02-05T13:16:59Z

Versions seem to be released roughly monthly and the last one was 21 days ago. So it shouldn't be too long I think.

nixbitcoin · 2021-02-25T11:11:28Z

Fixups

Apply and we should be ready for merge

erikarvstedt · 2021-02-25T11:51:23Z

Fixups of the fixups. (Guys, we've finally reached peak fixups.)

sputn1ck · 2021-03-01T12:42:47Z

Fixups of the fixups. (Guys, we've finally reached peak fixups.)

Pushed the fixups. Is it ready now? 😄

erikarvstedt

ACK eb21012

nixbitcoin

jonasnick · 2021-03-01T21:52:58Z

Excellent, thanks everyone!

sputn1ck force-pushed the lightning-pool branch from 43ac56f to a41e656 Compare February 1, 2021 16:48

nixbitcoin reviewed Feb 2, 2021

View reviewed changes

sputn1ck force-pushed the lightning-pool branch from cfbb7b8 to a6019c8 Compare February 3, 2021 09:40

sputn1ck force-pushed the lightning-pool branch from a6019c8 to d605c31 Compare February 3, 2021 12:36

nixbitcoin previously approved these changes Feb 3, 2021

View reviewed changes

sputn1ck mentioned this pull request Feb 3, 2021

Faraday #219

Open

jonasnick reviewed Feb 3, 2021

View reviewed changes

sputn1ck dismissed nixbitcoin’s stale review via de1f962 February 3, 2021 13:08

sputn1ck force-pushed the lightning-pool branch from d605c31 to de1f962 Compare February 3, 2021 13:08

sputn1ck commented Feb 3, 2021

View reviewed changes

sputn1ck force-pushed the lightning-pool branch from de1f962 to 94f8e52 Compare February 3, 2021 14:20

sputn1ck force-pushed the lightning-pool branch from 94f8e52 to 542dc09 Compare February 3, 2021 19:54

pool: add pkg, module & tests

eb21012

sputn1ck force-pushed the lightning-pool branch from 542dc09 to eb21012 Compare March 1, 2021 12:36

erikarvstedt approved these changes Mar 1, 2021

View reviewed changes

nixbitcoin approved these changes Mar 1, 2021

View reviewed changes

jonasnick merged commit 820de2e into fort-nix:master Mar 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lightning pool #313

Lightning pool #313

sputn1ck commented Feb 1, 2021

erikarvstedt commented Feb 1, 2021

Kixunil commented Feb 2, 2021

nixbitcoin Feb 2, 2021

sputn1ck Feb 2, 2021

nixbitcoin Feb 2, 2021

sputn1ck commented Feb 2, 2021

nixbitcoin commented Feb 2, 2021 •

edited

sputn1ck commented Feb 3, 2021

nixbitcoin commented Feb 3, 2021

nixbitcoin left a comment

jonasnick left a comment

sputn1ck Feb 3, 2021

sputn1ck commented Feb 3, 2021

nixbitcoin commented Feb 3, 2021

erikarvstedt commented Feb 3, 2021

sputn1ck commented Feb 3, 2021

erikarvstedt commented Feb 3, 2021

sputn1ck commented Feb 5, 2021

erikarvstedt commented Feb 5, 2021

jonasnick commented Feb 5, 2021

Kixunil commented Feb 5, 2021

nixbitcoin commented Feb 25, 2021

erikarvstedt commented Feb 25, 2021

sputn1ck commented Mar 1, 2021

erikarvstedt left a comment

nixbitcoin left a comment

jonasnick commented Mar 1, 2021

Lightning pool #313

Lightning pool #313

Conversation

sputn1ck commented Feb 1, 2021

erikarvstedt commented Feb 1, 2021

Kixunil commented Feb 2, 2021

nixbitcoin Feb 2, 2021

Choose a reason for hiding this comment

sputn1ck Feb 2, 2021

Choose a reason for hiding this comment

nixbitcoin Feb 2, 2021

Choose a reason for hiding this comment

sputn1ck commented Feb 2, 2021

nixbitcoin commented Feb 2, 2021 • edited

sputn1ck commented Feb 3, 2021

nixbitcoin commented Feb 3, 2021

nixbitcoin left a comment

Choose a reason for hiding this comment

jonasnick left a comment

Choose a reason for hiding this comment

sputn1ck Feb 3, 2021

Choose a reason for hiding this comment

sputn1ck commented Feb 3, 2021

nixbitcoin commented Feb 3, 2021

erikarvstedt commented Feb 3, 2021

sputn1ck commented Feb 3, 2021

erikarvstedt commented Feb 3, 2021

sputn1ck commented Feb 5, 2021

erikarvstedt commented Feb 5, 2021

jonasnick commented Feb 5, 2021

Kixunil commented Feb 5, 2021

nixbitcoin commented Feb 25, 2021

erikarvstedt commented Feb 25, 2021

sputn1ck commented Mar 1, 2021

erikarvstedt left a comment

Choose a reason for hiding this comment

nixbitcoin left a comment

Choose a reason for hiding this comment

jonasnick commented Mar 1, 2021

nixbitcoin commented Feb 2, 2021 •

edited