Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion #647

Closed
wants to merge 2 commits into from
Closed

Conversation

RCasatta
Copy link

Would be cool to have shell completion for the nix installed bitcoin binaries! (also in nixpkgs bitcoin, but I started here)

This is just a draft for multiple reasons:

  • on top of upgrade bitcoin package from nixpkgs #646 which was not right
  • doesn't work (the nix build is successful but the resulting image hasn't shell completion for bitcoin-cli)
  • it is missing shell completion for other bins
  • it makes sense to have completion also withGui
  • I am not sure targeting directly the build dir for finding completionion files is right

At the moment I am not going to work on this, however, I wanted to leave it here in case me of the future want to retry or someone else want to start from here

@prusnak
Copy link
Contributor

prusnak commented Sep 18, 2023

I will gladly review any PR to nixpkgs when it is ready, just tag me in the PR description.

@erikarvstedt
Copy link
Collaborator

I've created an upstream PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants