Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements (memory, bot client, containers) #745

Merged

Conversation

canercidam
Copy link
Contributor

@canercidam canercidam commented Jun 5, 2023

  • Updated forta-core-go to take @aomerk's memory usage improvements in Reduce marshal/unmarshal usage for proto conversions forta-core-go#239
  • Removing the unsafe.Pointer hack in gRPC message encoding: It seems to do the inverse of what we expected. The memory usage is lower and less aggressive without it.
  • Reusing top-level bot context to implement the "closed" state for the bot and making the input processing loops mind the cancellation of this context
  • Removing container images only when unused bots are cleaned up and some bots are removed (not during node exit as the images will be reused after node restart)

@canercidam canercidam merged commit 25763c5 into master Jun 6, 2023
1 check passed
@canercidam canercidam deleted the caner/forta-993-improve-request-channel-deallocation branch June 6, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants