Add support of customizing RNG for crypto algorithms #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 95.32% 95.45% +0.12%
==========================================
Files 19 20 +1
Lines 2674 2750 +76
==========================================
+ Hits 2549 2625 +76
Misses 125 125 ☔ View full report in Codecov by Sentry. |
Taowyoo
force-pushed
the
yx/ffdhe-custom-rng-support_master
branch
from
b1d5486
to
bbb909d
Compare
Taowyoo
force-pushed
the
yx/ffdhe-custom-rng-support_master
branch
from
6999404
to
64cfa72
Compare
Taowyoo
changed the title
Taowyoo
changed the title
xinyufort
approved these changes
Apr 12, 2024
Taowyoo
force-pushed
the
yx/ffdhe-custom-rng-support_master
branch
from
492d7c3
to
55592de
Compare
zugzwang
reviewed
Apr 15, 2024
Taowyoo
force-pushed
the
yx/ffdhe-custom-rng-support_master
branch
from
bdb28aa
to
25935a1
Compare
|
Hi folks, I just refactor and create the wrapper type in a clearer way:
I did not change all types that contains CC: @zugzwang @xinyufort |
Current two RNG we provided in this crate does not meet FIPS requirements. So, this commit updates all crypto algorithms that need to use RNG to have a function pointer for creating RNG. In this way, user could customize the RNG they want to use for each algorithm. Other Changes: - Add unit tests. - Fix clippy warnings.
- Remove derived Debug implementation on ` agreement::Algorithm`. - Update unit test. - Improve rustdoc for `MbedRng`.
fix rustdoc warning
- Refactor and rename `KxGroup` to `KxGroupWrapper`. - Rename `KeyExchange` to `KeyExchangeImpl`. - Refactor and rename `DheKxGroup` to `DheKxGroupWrapper`. - Rename `DheActiveKeyExchange` to `DheActiveKeyExchangeImpl`. - Refactor and rename `MbedTlsPkSigningKey` to `MbedTlsPkSigningKeyWrapper`. - Update unit tests accordingly.
Taowyoo
force-pushed
the
yx/ffdhe-custom-rng-support_master
branch
from
25935a1
to
9c6b488
Compare
Taowyoo
requested review from
xinyufort and
zugzwang
and removed request for
zugzwang
zugzwang
reviewed
Apr 16, 2024
zugzwang
reviewed
Apr 16, 2024
zugzwang
requested changes
Apr 16, 2024
zugzwang
reviewed
Apr 17, 2024
zugzwang
approved these changes
Apr 17, 2024
xinyufort
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR picks changes in #64 to master.
Background
Current two RNG we provided in this crate does not meet FIPS requirements.
So, this PR updates all crypto algorithms that need to use RNG to have a function pointer for creating RNG. In this way, user could customize the RNG they want to use for each algorithm.
Changes
fn with_rng_providerto enable user to choose RNG for each crypto algorithm implementation.pub, so user could easily customize current crypto algorithm implementations.Dereftrait guard.