Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to do a half-filled star? #38

Closed
codeofsumit opened this issue Jan 5, 2018 · 3 comments
Closed

how to do a half-filled star? #38

codeofsumit opened this issue Jan 5, 2018 · 3 comments

Comments

@codeofsumit
Copy link

As star-half-o is now gone from FontAwesome 5, how can I create a half filled star? If I put two half-star from solid and regular next to each other, flip one - there is too much spacing in between them obviously.
image

@robmadole
Copy link
Member

Hi @codeofsumit here is an example that we've worked up for this specific thing https://codepen.io/fontawesome/pen/GyjamK

@dannosaur
Copy link

That's ridiculous. What was previously a single line of HTML has now turned into a 4-fold increase AND requires additional detection logic in code that generates the star output to know that the previous star was a half filled star, thus requiring even more HTML to complete the previous star. How was it decided that it was better this way?

@robmadole
Copy link
Member

@dannosaur we worked with the community to come to this decision. Sorry you don't agree but this new solution is more robust and makes some things possible that were not with the old design. We opted to listen to the requests that we had for this set of icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants