New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite of minor modernizations and code improvements #116

Open

shrikeh wants to merge 2 commits into forter:master from shrikeh:master

shrikeh commented Sep 8, 2023

Removed unused private variables
Declared visibility on constants
Checked for identity === instead of equality == on string scalars.
Enforced type hinting where the method could only possibly work with a collaborator of a specific type (e.g. Order)
Added type returns on methods that must be void
Added Magento and PHPUnit as a require-dev dependency.

Todo: Lots, but this is a start.

Barney Hanlon added 2 commits

September 8, 2023 12:17


          Suite of minor modernizations and code improvements

1ccc49c


          Add newline to .gitignore

e63b27a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment