Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 62 allow to not terminate unhealthy vm #67

Merged

Conversation

JaydenLiang
Copy link
Contributor

resolve: #62

@JaydenLiang JaydenLiang force-pushed the feat_62_allow_to_not_terminate_unhealthy_vm branch from 73d8d05 to a613202 Compare July 28, 2021 01:52
@JaydenLiang JaydenLiang force-pushed the feat_62_allow_to_not_terminate_unhealthy_vm branch from a613202 to bfb2403 Compare July 28, 2021 01:57
Copy link
Member

@Joel-Cripps Joel-Cripps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good idea with the deleteVM toggle. I would set this to false by default.

@JaydenLiang
Copy link
Contributor Author

Looks good. Good idea with the deleteVM toggle. I would set this to false by default.

however, as an outcome, the vm will still be deemed out-of-sync by the Autoscale and will be excluded from primary election. Users need to manually delete the autoscale record to make it in-sync again.

see #70

@JaydenLiang JaydenLiang merged commit d57cb04 into staging_project_1 Jul 29, 2021
@JaydenLiang JaydenLiang deleted the feat_62_allow_to_not_terminate_unhealthy_vm branch July 29, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants