Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return non 0 status (shell error) for grpcping -health #588

Closed
ldemailly opened this issue Jun 6, 2022 · 0 comments · Fixed by #589
Closed

return non 0 status (shell error) for grpcping -health #588

ldemailly opened this issue Jun 6, 2022 · 0 comments · Fixed by #589

Comments

@ldemailly
Copy link
Member

fortio curl already returns 0 for 200 and 1 for non 200, let's do the same for grpc health SERVING
ldemailly added a commit that referenced this issue Jun 7, 2022
@ldemailly
exit with status 1 if grpcping -health isn't SERVING. fixes #588
77ff17f
@ldemailly ldemailly mentioned this issue Jun 7, 2022
Merged
ldemailly added a commit that referenced this issue Jun 21, 2022
@ldemailly
exit with status 1 if grpcping -health isn't SERVING. (#589)
588306d 
* exit with status 1 if grpcping -health isn't SERVING. fixes #588

* add a _down grpc server that will be always NOT_SERVING

* add a test for _down

* add also status e2e test and preop for 1.33.0

* fix the status test

* fix #595

* added test and avoid using filtered / string version unless necessary (basically only grpc ping)
ldemailly added a commit that referenced this issue Jun 21, 2022
@ldemailly
dflags generics - added WithInputMutator and WithValueMutator too (#593)
6626cd6 
* exit with status 1 if grpcping -health isn't SERVING. fixes #588

* add a _down grpc server that will be always NOT_SERVING

* add a test for _down

* add also status e2e test and preop for 1.33.0

* fix the status test

* Use generics to tremendously shrink/improve the dflag/ code (left the tests unchanged or added to them to test indeed the implementation is compatible; they could be cleaned as well

* Add test for Parse error case. Added test in logger to cover the setting normalization

* update the sample and move the common stuff into the new generic file, add one more test

* use type aliases for backward compatibility

* added slice and set to generics version

* linter

* last one: dynjson; also improve testify compatibility by showing actual line numbers

* had to remove IsBoolFlag from generic because of golang/go#53473 - added tests for PrintDefaults output checking for 3 cases

* linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exit with status 1 if grpcping -health isn't SERVING. fortio/fortio
1 participant
@ldemailly