Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't rely on syscall.Kill to interrupt a run / make fortio works on Windows #63

Closed
ldemailly opened this issue Dec 26, 2017 · 0 comments · Fixed by #64
Closed

don't rely on syscall.Kill to interrupt a run / make fortio works on Windows #63

ldemailly opened this issue Dec 26, 2017 · 0 comments · Fixed by #64
Assignees
@ldemailly
Labels
enhancement

Comments

@ldemailly
Copy link
Member

ldemailly commented Dec 26, 2017 •
edited

I just discovered fortio doesn't run on windows:

C:\Users\l\go\src\istio.io>go get -u istio.io/fortio
# istio.io/fortio/ui
fortio\ui\uihandler.go:181:3: undefined: syscall.Kill

Ignoring for a second that go should provide a kill emulation (imo) - we probably should cleanup fortio anyway as it's only to interrupt itself

(we can also remove the exit option from the UI and only interrupt a given run or maintain a stack or list of them - or interrupt all of them through a shared channel)
ldemailly added a commit that referenced this issue Dec 27, 2017
@ldemailly
fix compilation error
47e870f 
but still not working
partial fix for #63
@ldemailly ldemailly mentioned this issue Dec 27, 2017
Merged
@ldemailly ldemailly self-assigned this Dec 27, 2017
ldemailly added a commit that referenced this issue Dec 28, 2017
@ldemailly
interrupt properly each run through channel (and side effect fix comp…
89a8ded 
…ilation error and works on windows) (#64)

Fix for #63 

* fix windows compilation error

* Now use separate channel to interrupt runs

* Now can interrupt specific/correct run for each window/UI

* Allow save+json to both work together

* Changed the signal handling to be fully correct

*  ^C interrupts all outstanding runs (while the UI can interrupt 1 (from each run window) or all (from the main page) depending on parameter)

* Also need to use a copy of the channel in loops to not wait on nil

* Add windows compile check + code review comments + lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldemailly ldemailly

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@ldemailly