Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of integration with chartjs #14

Merged
merged 8 commits into from
Nov 9, 2017
Merged

Initial version of integration with chartjs #14

merged 8 commits into from
Nov 9, 2017

Conversation

ldemailly
Copy link
Member

Draw the histogram and cumulative %

Fixes #13
Fixes #12

Draw the histogram and cumulative %

Fixes #13
@ldemailly
Copy link
Member Author

ldemailly commented Nov 8, 2017

it looks like this:
screen shot 2017-11-08 at 11 34 43 am

(Replaced mixed of tabs and space with just spaces in the JS section)
@ldemailly ldemailly mentioned this pull request Nov 8, 2017
14 tasks
Copy link
Collaborator

@ymesika ymesika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Chrome / Firefox and works well.
I still think the embedded HTML / JS is not the best way to handle web resources but it's a great start.

P.S. Tested it with duration -1s (for unlimited) but there is no way to stop it. In this case we may want to switch the start button into stop and keep it there. I can do it later on.

@@ -0,0 +1,14 @@
// This file is https://github.com/chartjs/Chart.js/releases/download/v2.7.1/Chart.min.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: any reason not to just include this as Chart.min.js? And serve it directly (via http.FileServer or similar)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to be able to ‘go get istio.io/fortio‘ and have everything - do you know a standard way for go binaries to find the source tree that build them?
(That would solve the go get case but not the scp the binary around and use it)

@ldemailly
Copy link
Member Author

Btw you can already today interrupt a -1 run by opening the main page in another tab and clicking Exit but yes we can make that better, this was just the first version I got working

@ldemailly ldemailly merged commit c9e67cd into master Nov 9, 2017
@ldemailly ldemailly deleted the chart branch November 9, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants