-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of integration with chartjs #14
Conversation
Draw the histogram and cumulative % Fixes #13
(Replaced mixed of tabs and space with just spaces in the JS section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Chrome / Firefox and works well.
I still think the embedded HTML / JS is not the best way to handle web resources but it's a great start.
P.S. Tested it with duration -1s (for unlimited) but there is no way to stop it. In this case we may want to switch the start button into stop and keep it there. I can do it later on.
@@ -0,0 +1,14 @@ | |||
// This file is https://github.com/chartjs/Chart.js/releases/download/v2.7.1/Chart.min.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: any reason not to just include this as Chart.min.js
? And serve it directly (via http.FileServer or similar)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to be able to ‘go get istio.io/fortio‘ and have everything - do you know a standard way for go binaries to find the source tree that build them?
(That would solve the go get case but not the scp the binary around and use it)
Btw you can already today interrupt a -1 run by opening the main page in another tab and clicking Exit but yes we can make that better, this was just the first version I got working |
Draw the histogram and cumulative %
Fixes #13
Fixes #12