Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to fix X axis min,max and switch to log on both axis #17

Merged
merged 4 commits into from Nov 13, 2017

Conversation

ldemailly
Copy link
Member

Ability to fix X axis max and switch to log on both axis

Also show the target url on page

(Needed to patch in
chartjs/Chart.js#4198
In order to get chartjs/Chart.js#4939
Axis type switching to work)

Ignore 0 for min when in log
@ldemailly ldemailly changed the title Ability to fix X axis max and switch to log on both axis Ability to fix X axis min,max and switch to log on both axis Nov 11, 2017
Copy link
Collaborator

@ymesika ymesika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.
Works flawlessly on both Chrome/Firefox.

@ldemailly
Copy link
Member Author

Thx ! I test on chrome and safari mac myself

Added a custom build from my branch with all the fixes and removing the unused modules,
that shaved about 1/3rd of the minified size

ldemailly/Chart.js@d71f418

@ldemailly ldemailly merged commit 2a4a06a into master Nov 13, 2017
@ldemailly ldemailly deleted the uitweaks branch November 13, 2017 05:45
@ldemailly
Copy link
Member Author

note that you need to ctrl or shift reload to get the .js otherwise log won't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants