Allow disabled for grpc port too to skip without printing an error #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this works without spurious output:
```
$ fortio server --quiet --redirect-port "disabled" --grpc-port
"disabled" -http-port 0 -ui-path "" | awk '{print $7}'
[::]:64474
```
Manually tested
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
======================================
Coverage 90.2% 90.2%
======================================
Files 10 10
Lines 1905 1905
======================================
Hits 1719 1719
Misses 119 119
Partials 67 67Continue to review full report at Codecov.
|
|
no bots here :-) only use the github UI :-) I'm considering adding the server/daemon to this PR so not merging yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this works without spurious output:
Manually tested