Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also allow main echo/http port to be disabled; so a server can be sta… #559

Merged
merged 3 commits into from May 8, 2022

Conversation

ldemailly
Copy link
Member

…rted as just grpc-port for instance

@codeclimate
Copy link

codeclimate bot commented May 8, 2022

Code Climate has analyzed commit b54f174 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #559 (b54f174) into master (c79d0b1) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #559   +/-   ##
======================================
  Coverage    87.5%   87.5%           
======================================
  Files          26      26           
  Lines        3602    3602           
======================================
  Hits         3150    3150           
  Misses        302     302           
  Partials      150     150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79d0b1...b54f174. Read the comment docs.

@ldemailly ldemailly merged commit 6ff4fd6 into master May 8, 2022
@ldemailly ldemailly deleted the http-port-can-be-disabled branch May 8, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant