Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do abort early even with stdclient on bad urls/hosts. allow most same query args on fetchers. #785

Merged
merged 21 commits into from
Jul 4, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jun 30, 2023

Screenshot 2023-06-30 at 5 13 15 PM

instead of a run with 100% errors

  • Also use UI form params for fetch and fetch2 endpoints (so one can pass extra headers with &H=foo:bar and turn off secure fetch using https-insecure=on etc

@ldemailly ldemailly changed the title fix #784: do abort early even with stdclient on empty url and unresolvable host do abort early even with stdclient on empty url and unresolvable host Jul 1, 2023
@ldemailly ldemailly changed the title do abort early even with stdclient on empty url and unresolvable host do abort early even with stdclient on bad urls/hosts. allow most same query args on fetchers. Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.0% and project coverage change: +0.1 🎉

Comparison is base (fc1f4ba) 89.5% compared to head (9a754aa) 89.7%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #785     +/-   ##
========================================
+ Coverage    89.5%   89.7%   +0.1%     
========================================
  Files          17      17             
  Lines        4086    4141     +55     
========================================
+ Hits         3658    3713     +55     
  Misses        279     279             
  Partials      149     149             
Impacted Files Coverage Δ
fhttp/http_client.go 85.0% <100.0%> (+0.2%) ⬆️
fhttp/http_forwarder.go 91.0% <100.0%> (+0.8%) ⬆️
fhttp/http_server.go 85.9% <100.0%> (+0.2%) ⬆️
fhttp/http_utils.go 99.2% <100.0%> (+0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fhttp/http_client.go Show resolved Hide resolved
fhttp/http_client.go Show resolved Hide resolved
Base automatically changed from fix_780 to master July 3, 2023 23:23
@ldemailly ldemailly merged commit 8890d97 into master Jul 4, 2023
9 checks passed
@ldemailly ldemailly deleted the fix_784 branch July 4, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

putting an empty or invalid (non resolving) url doesn't abort early - UI and rapi
2 participants