Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default http config for all server UI and rapi operations + Indicate when the UI/echo server is using https #868

Merged
merged 7 commits into from Dec 9, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Dec 7, 2023

Fixes #865 by introducing DefaultHTTPOptions and copies of it after it's set by the main()

Also:

go run . server -key ./cert-tmp/server.key -cert ./cert-tmp/server.crt 
[...]
12:22:37.835 r1 Using server cert and key from ./cert-tmp/server.crt and ./cert-tmp/server.key to construct TLS credentials
12:22:37.835 r1 Fortio dev https redirector server listening on tcp [::]:8081
12:22:37.835 r1 Fortio dev https-echo server listening on tcp [::]:8080
12:22:37.845 r1 Data directory is /Users/ldemailly/dev/fortio.org/fortio
12:22:37.845 r1 REST API on /fortio/rest/run, /fortio/rest/status, /fortio/rest/stop, /fortio/rest/dns
12:22:37.845 r1 Debug endpoint on /debug, Additional Echo on /debug/echo/, Flags on /fortio/flags, and Metrics on /debug/metrics
	 UI started - visit:
		https://localhost:8080/fortio/
	 (or any host/ip reachable on this server)

used to say http://localhost:8080/ for that case

@ldemailly ldemailly changed the title Indicate when the UI/echo server is using https Indicate when the UI/echo server is using https and use the default http config for all server UI and rapi operations Dec 8, 2023
@ldemailly ldemailly changed the title Indicate when the UI/echo server is using https and use the default http config for all server UI and rapi operations Use the default http config for all server UI and rapi operations + Indicate when the UI/echo server is using https Dec 8, 2023
Base automatically changed from go_1_21_5 to master December 8, 2023 22:53
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80eca80) 88.5% compared to head (5906e7c) 88.6%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #868   +/-   ##
======================================
  Coverage    88.5%   88.6%           
======================================
  Files          17      17           
  Lines        5011    5014    +3     
======================================
+ Hits         4437    4440    +3     
  Misses        424     424           
  Partials      150     150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldemailly ldemailly merged commit 6b492e2 into master Dec 9, 2023
9 checks passed
@ldemailly ldemailly deleted the https_ui branch December 9, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add cacert key cert to UI
2 participants