Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml/s3 bucket transfer support #96

Merged
merged 4 commits into from Jan 24, 2018
Merged

Xml/s3 bucket transfer support #96

merged 4 commits into from Jan 24, 2018

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jan 23, 2018

example/test:
https://storage.googleapis.com/fortio-data?max-keys=2

fixes #95

(This feature is pretty big and would be 0.7.0 but… trying to not get
too much ahead of the monthly istio cycle)

example/test:
https://storage.googleapis.com/fortio-data?max-keys=2

(This feature is pretty big and would be 0.7.0 but… trying to not get
too much ahead of the monthly istio cycle)
@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #96 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #96     +/-   ##
========================================
+ Coverage    86.4%   86.8%   +0.4%     
========================================
  Files           6       6             
  Lines        1371    1346     -25     
========================================
- Hits         1184    1168     -16     
+ Misses        134     126      -8     
+ Partials       53      52      -1
Impacted Files Coverage Δ
periodic/periodic.go 97.5% <ø> (ø) ⬆️
fgrpc/grpcrunner.go 75.8% <0%> (+5.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785fb3b...aa5a781. Read the comment docs.

Fixes #92
As we can now add -sync to yaml to load data on startup
@ldemailly ldemailly merged commit 44d1e6e into master Jan 24, 2018
@ldemailly ldemailly deleted the xml_bucket_transfer branch January 24, 2018 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support download from amazon/google storage buckets
3 participants