Add function tests #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wnadeau so wait, what was the issue? |
|
get a passing build on solano before it gets merged |
|
we need to get much more into the habit of running the hired/hired test suite with large new development in fortitude. lots of useful signal about "shit that these changes will break" in there. my point: these changes caused a lot of failures in hired/hired, so it's important that we get whatever visual regression is happening sorted before this goes into fortitude/fortitude-sass:master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alright @lifeiscontent more work is needed on this PR to iron out what changes inside of it are breaking our app's build.
From here, we'll need to just point Hired at this PR and get a passing build on solano before it gets merged.
Reverts #33