update requirements.txt in order to drop of python2 support #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the clarification. We will review this one for sure, as we suspect that pyreadline is not being currently used in the project (despite being referenced in the code and dependencies.. ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fully about windows environment.
pyreadlinemodule is not supporting new versions of python 3.x, as specified in documentation here:Version 2.1 of pyreadline has been verfied for Python 2.7, and 3.4, 3.5.Since Impacket continues growing by Python3, we need to update dependencies (requirements.txt).
pyreadline3is the new version of its previous version and supports more recent versions of python3, as specifications in document.