Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in logic to skip big or incomplete graphs #627

Closed
mscfd opened this issue Feb 26, 2024 · 1 comment
Closed

Bug in logic to skip big or incomplete graphs #627

mscfd opened this issue Feb 26, 2024 · 1 comment

Comments

@mscfd
Copy link

mscfd commented Feb 26, 2024

The condition in the if line in

        # Do not render overly large graphs.
        if len(self.added) > self.max_nodes and self.warn:
            warn(
                f"Not showing graph {self.ident} as it would exceed the maximal number of {self.max_nodes} nodes"
            )
            return ""

in graphs.py (line ca. 900) has been mangled in commit b497ad8.

Independently of self.warn, if the first condition holds, then return an empty string.

There is another such test below this code block.

@ZedThree
Copy link
Member

Thanks for catching this @mscfd!

mscfd pushed a commit to mscfd/ford that referenced this issue Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants