Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parser for modularity #333

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Refactor parser for modularity #333

merged 5 commits into from
Jan 2, 2024

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Oct 23, 2023

Breaks the AST nodes of the parser into separate module files.
Important to keep the code clean.

TODO:

  • Increase converage
  • Fix poor quality code Issues
  • Simpligy certain parts of the AST nodes

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 254 lines in your changes are missing coverage. Please review.

Comparison is base (b06a833) 87.54% compared to head (df9f621) 87.51%.

Files Patch % Lines
fortls/parsers/internal/type.py 61.06% 44 Missing ⚠️
fortls/parsers/internal/ast.py 86.19% 33 Missing ⚠️
fortls/parsers/internal/subroutine.py 83.43% 28 Missing ⚠️
fortls/parsers/internal/utilities.py 86.55% 25 Missing ⚠️
fortls/parsers/internal/variable.py 84.41% 24 Missing ⚠️
fortls/parsers/internal/scope.py 86.52% 19 Missing ⚠️
fortls/parsers/internal/function.py 77.92% 17 Missing ⚠️
fortls/parsers/internal/method.py 79.26% 17 Missing ⚠️
fortls/parsers/internal/base.py 84.33% 13 Missing ⚠️
fortls/parsers/internal/submodule.py 89.47% 8 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   87.54%   87.51%   -0.04%     
==========================================
  Files          12       35      +23     
  Lines        4567     4756     +189     
==========================================
+ Hits         3998     4162     +164     
- Misses        569      594      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnikit gnikit changed the title Refactor the Refactor parser for modularity Oct 29, 2023
This had to happen in a single commit to ensure that circular
dependencies were correclty resolved.

## TODO:
- Increase converage
- Fix poor quality code Issues
- Simpligy certain parts of the AST nodes
@gnikit
Copy link
Member Author

gnikit commented Jan 2, 2024

I have gone line by line-by-line through the newly created files and the coverage is identical (bar a +1 line coverage in the BLOCK AST node, function req_named_end).

@gnikit gnikit merged commit 8263781 into master Jan 2, 2024
33 of 35 checks passed
@gnikit gnikit deleted the refactor/modular-parser branch January 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant