Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes update intrinsics action #362

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

azzamh15
Copy link
Contributor

@azzamh15 azzamh15 commented Mar 16, 2024

This fixes update instrinsics action #358 after updating the file paths according to new architecture. Tested the workflow by manually triggering it,works fine.

@azzamh15 azzamh15 requested a review from gnikit as a code owner March 16, 2024 06:23
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (3386073) to head (1a3f2f7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          35       35           
  Lines        4760     4760           
=======================================
  Hits         4166     4166           
  Misses        594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gnikit gnikit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I think you should be using Path since the directories now are rather nested.

fortls/parsers/internal/intrinsics.py Outdated Show resolved Hide resolved
@gnikit gnikit linked an issue Mar 19, 2024 that may be closed by this pull request
@gnikit gnikit merged commit bea550a into fortran-lang:master Mar 19, 2024
20 checks passed
@azzamh15 azzamh15 deleted the update-intrinsic-action branch March 31, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ci): update Intrinsics Action is broken
2 participants