Add library-dir to support -Lpath
#671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 9, 2022
Open
zoziha
commented
Mar 9, 2022
| @@ -37,6 +37,7 @@ subroutine default_library(self) | |||
|
|
|||
| self%source_dir = "src" | |||
| self%include_dir = [string_t("include")] | |||
| self%library_dir = [string_t("lib")] | |||
There was a problem hiding this comment.
library-dir defaults to lib.
Comment on lines
+1
to
+9
| name = "minpack" | ||
|
|
||
| [library] | ||
| include-dir = ["inc"] | ||
| library-dir = ["src"] | ||
|
|
||
| [build] | ||
| link = "minpack" | ||
| external-modules = ["minpack_module"] |
There was a problem hiding this comment.
These four features allow fpm to distribute binary link libraries, like minpack.
|
Rethinking the value of this PR, it seems that this feature does not need to be implemented. :\ Currently, we can mostly set the system or temporary I will close this PR tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library-dirinfpm.tomlto support-Lpath;minpackas a demo of this new feature;Description
-Lpathmakes it possible to distribute large libraries such asstdlib,OpenBLAS,HDF5,MKL, etc., and to package compiled.modand.a/.dll/.so/.dll.afiles into fpm distribution.