New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Fix for README #101
Conversation
@everythingfunctional This reminds me of a question I wanted to ask about the instructions for installing stack: why does the README recommend following the 'Manual Download' instructions as opposed to using the simpler install script or distribution package managers? I used the Ubuntu distribution package followed by running The instructions for installing stack are pleasantly comprehensive (and cross-platform!) and I think we should simply refer users to this page and allow them to choose their preferred installation method. |
…kell tool stack documentation instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a positive change, as our specific instruction was Linux only.
Thank you @milancurcic for approving this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @everlookneversee , I agree this is an improvement.
Unless Brad had a specific reason for recommending the manual installation method, I think this is good to merge with one change: can you revert 7ee74b1?
Ok, I'll revert it. |
This reverts commit 7ee74b1
@certik wanted to support people who didn't have sudo access to install system wide. I agree that the official stack install instructions are generally the preferred way, so I support this change. We may want to have a separate section to put the manual install instructions somewhere just in case. |
I would like to keep it in some form, as requiring a sudo access is a non-starter on almost any machine where I would like to use fpm (I don't have sudo access). |
I agree. Could this link just be mentioned to replace the deleted section. Furthermore, all OS are described there. |
I think that link would work. |
@certik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This is a fixup of fortran-lang#101.
@certik Thanks for merging. |
Separating navigating to stack directory and Adding to PATH
Because some of users may navigate to stack directory first and and enter this command(export PATH="$PATH:pwd/stack-2.1.3-linux-x86_64-static/) in order to install stack command that causes error below in $PATH: