Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different strategy to fetch git dependencies #163

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Sep 5, 2020

  • matches strategy of GitHub's actions/checkout workflow
  • use init -> fetch -> checkout -qf FETCH_HEAD instead of current clone [-> checkout] strategy
  • always works in detached HEAD
  • allows to update the git dependency with the same commands (Related: github dependencies are never updated #121)
  • change directory with -C command (easier to match for later Fortran implementation, available since git 1.8.5)

Can probably be implemented much nicer, but my Haskell skills don't go beyond the Try it! tutorial on haskell.org

- use init -> fetch -> checkout -qf instead of current clone [-> checkout] strategy
@awvwgk awvwgk marked this pull request as draft September 5, 2020 19:45
@everythingfunctional
Copy link
Member

I was unaware of the -C path option for git. I think this is a good idea, if for no other reason than the Fortran implementation can use exactly the same commands.

As for the implementation, I'm not sure I would have done it any different.

@awvwgk awvwgk marked this pull request as ready for review September 8, 2020 20:47
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the Haskell code but the PR description looks good, so 👍 from me.

Copy link
Member

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as tests pass and things still work, the change looks ok.

@milancurcic milancurcic merged commit f641aae into fortran-lang:master Sep 15, 2020
@awvwgk awvwgk deleted the fetch branch September 15, 2020 18:51
@awvwgk awvwgk mentioned this pull request Apr 18, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants