Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in contributing guidelines #342

Merged
merged 1 commit into from Jan 30, 2021
Merged

Fix broken link in contributing guidelines #342

merged 1 commit into from Jan 30, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jan 23, 2021

Closes #340

LKedward
LKedward approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@LKedward
Copy link
Member

CI passes after rerunning so not sure if there's some non-determinism (?) in the tests. Think it was the 'help_test' that failed. (This test is actually a little problematic since it invokes fpm run to run Fortran fpm, but this doesn't test the release flags properly.)

@awvwgk
Copy link
Member Author

awvwgk commented Jan 23, 2021

Think it was the 'help_test' that failed. (This test is actually a little problematic since it invokes fpm run to run Fortran fpm, but this doesn't test the release flags properly.)

I opened #343 to discuss this.

@awvwgk
Copy link
Member Author

awvwgk commented Jan 30, 2021

Since this is a simple change, I'll go ahead and merge.

@awvwgk awvwgk merged commit a16e812 into fortran-lang:master Jan 30, 2021
@awvwgk awvwgk deleted the broken-link branch January 30, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKedward LKedward LKedward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link in contributing guide is broken
2 participants
@awvwgk @LKedward