Implement test/executable specific dependencies

[everythingfunctional]

At this point it's kind of a terrible, ugly, hacked together prototype, but it works. And allows for "semi"-circular dependencies. If one of your test or executable dependencies depends on your library, it will still work.

[everythingfunctional]

My use case for this is that vegetables depends on both iso_varying_string and strff, but I want to be able to use vegetables to test them. This way that will work.

I still need to try to migrate these to using fpm to be sure that it will work, but I'll try that over the next day or two. The test I added suggests it will.

[certik]

Yes, we need this feature. However, let's follow the Cargo's syntax? Or do you have reasons why that's not a good idea in this case?

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#development-dependencies

It has [dependencies] for just building the package, and additional [dev-dependencies] for building tests / benchmarks etc.

Currently you have:

[[test]]
  name = "test"
  source-dir = "tests"
  main = "main.f90"
  [test.dependencies]
    circular_test = { path = "../circular_test" }

Let's instead do:

[dev-dependencies]
    circular_test = { path = "../circular_test" }

[[test]]
  name = "test"
  source-dir = "tests"
  main = "main.f90"

And finally fpm should be clever enough to figure out the tests from the layout only (eventually), so it would become just:

[dev-dependencies]
    circular_test = { path = "../circular_test" }

In Cargo you can specify also dependencies for a particular target only. But it seems this dev-dependencies would cover 90% of use cases, including yours (I think).

[certik]

My other comment is that instead of adding tests in the root directory as examples, let's move them in the tests directory?

[everythingfunctional]

I'm not opposed to also having [dev-dependencies], but my question would be, are those used for the executables too? Or would we want to have [test-dependencies] and [exe-dependencies]?

I can move the tests into the tests directory. That's no problem.

[everythingfunctional]

I was able to try this out converting a few of my libraries to using fpm, and it works great. This will make it possible for me to convert (almost) all of my packages to fpm.

[certik]

I am not sure about the executables --- I would expect that dev-dependecies only work for tests, benchmarks etc.

In your use case, you have to have special dependencies for executables?

[everythingfunctional]

I don't personally have a project with special dependencies for an executable, but I could envision one. Somebody develops and tool, and there's a library that goes along with it, but the executable has dependencies that user's of the library don't necessarily need. The use case is probably rare enough, and covered by the executable/test specific dependencies I've already implemented that having dev-dependencies only for tests is probably fine. I'll get that implemented.

[certik]

Yes, I think that's precisely the approach that Cargo took also. For this rare case, you just specify the dependency for the executable that needs it. Otherwise the dependencies and dev-dependencies cover over 90% of use cases. Thanks for all the work you are doing on this.

…

On Sun, May 31, 2020, at 5:21 PM, Brad Richardson wrote: I don't personally have a project with special dependencies for an executable, but I could envision one. Somebody develops and tool, and there's a library that goes along with it, but the executable has dependencies that user's of the library don't necessarily need. The use case is probably rare enough, and covered by the executable/test specific dependencies I've already implemented that having `dev-dependencies` only for tests is probably fine. I'll get that implemented. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWCG44ZNP5I7MSX2U3LRULQ6BANCNFSM4NOQBL6A>.

[certik]

I think this looks good to me to merge.

The [dev-dependencies] is working, tests are added, so we can improve upon this with subsequent PRs.

Thank you Brad! I think we are getting very close to make fpm usable in real projects.

I'll try this myself on my projects soon.

[milancurcic]

Sorry, I don't have time to review this but please go forward with it and I will play with it at a later time.

[milancurcic]

I reviewed the examples and the addition to the guide, all looks good to me.